peg_nested_comments

31 October 2012, 10:26

Keywords: comment, thread

Testing modified peg_nested_comments plugin. The modifications include:

proper nesting;
sanitation;
working sort attribute;
some JS goodness.

Please test and comment. :)

Info and download

https://github.com/bloatware/peg_nested_comments

Comments

etc · 31 October 2012, 10:32 — Reply

First comment.
1. etc · 31 October 2012, 10:33 — Reply
  
  Reply to the first comment.
  1. etc · 31 October 2012, 10:33 — Reply
    
    Reply to reply.
    1. uli · 31 October 2012, 14:53 — Reply
      
      And now: where do I get shelved when I reply to my first comment?
      1. uli · 31 October 2012, 15:01 — Reply
        
        So, either the two column layout is keeping me from understanding the nesting system or I’m continually clicking the wrong reply-link.
        Or the plugin doesn’t shelve replies correctly. Last test for today: this is a reply to my post from 02:53 PM.
  2. uli · 31 October 2012, 14:28 — Reply
    
    I’ve tried whether I could make it work on 441 some months ago, had it nesting, and then remarked that even an answer to the first comment got nested at the very end of the queue and one more level deep than the latest existing one, thus building the east side of a pretty pyramid. Must have been the curse of the egyptian urn ash.
    Nice, Oleg!
  3. uli · 31 October 2012, 14:50 — Reply
    
    Hm, is this here also building pyramids: I don’t think I commented on the last comment. So this is just a test: replying to the very first comment in order to see whether this one here also lands at the end of the queue and how deep indented it’ll be.
    1. etc · 31 October 2012, 15:41 — Reply
      
      Hi Uli, thank you for being the first (after Donald Swain) commenter! :)
      
      The replies are nested one level deeper than their parent, is this wrong?
2. etc · 31 October 2012, 15:37 — Reply
  
  Delayed reply to the very first comment, should be on the first line.
3. milosevic · 9 December 2012, 20:43 — Reply
  
  Lets try a reply to first comment!
uli · 31 October 2012, 20:47 — Reply

The replies are nested one level deeper than their parent, is this wrong?

No, not at all. It’s rather this:

Delayed reply to the very first comment, should be on the first line.

At the moment, comment-level-3 on comment-level-2 on comment-level1 sits higher on the page than comment-level-2 on comment-level-1”:#c000009, i.e. for reading a reaction on comment-level-1 I have to skip some level-3 in between. I’d not say it is wrong, it just feels wrong.

I hope this is clear enough. Perhaps there’s a sorting mechanism I don’t understand?
1. uli · 31 October 2012, 20:58 — Reply
  
  Alright, now that I squeezed the window and have a 1-col-layout I can see what you meant by “should be on the first line” (dotted line = what I called level). So at least my quoting might confuse you more than serve clarity ;p
  
  BTW: Nice that one can change the parent comment relation by simply clicking its related hash mark without loosing an already typed comment.
2. etc · 31 October 2012, 21:07 — Reply
  
  Ah yes. But where would you like to display #c000011 which replies to #c000010 which replies to #c000006 which is prior to #c000009? I do not see how to combine chronological and hierarchical order, any ideas or examples? One could easily make them collapsible, though.
  1. uli · 1 November 2012, 21:47 — Reply
    
    Oleg, you were twice right in your replies, and I couldn’t provide a technical/logical solution. Of course. As the hierarchy works the same as usual indented commenting systems work.
    
    But that made me think my problem in understanding the “construction” at first sight might come from somewhere else, like the two column layout I already commented on.
    
    What added to myconfusion while analysing the structure was the am/pm date format: I couldn’t change that myself.
    What I could change was the distance between the actual post and the post’s data: It made the data part look like a post itself, so in Firebug I reduced that distance and set p.small’s margin-top to -1em. Better (though not a clean solution for the rest of your site. Better: fiddling with a container’s CSS around the comments’ paragraphs).
    
    Next thing were the m-dashes in front of the commenter’s names, that added to the indentation look of the p.small lines. Easily removed with Firebug.
    
    Then I found that the dotted border-left was adding to my confusion, as it introduced another level of indentation: it started with an offset of 1em from the parent’s left edge. So I made the child’s border aligned with it by removing margin-left from ul.comments and adding that 1em to its padding left, so it ended with 2em padding-left and kept its original distance from the next level.
    
    Screenshot:
    http://i48.tinypic.com/o8xiyo.png
    
    Now, when I look at it I think that children comments actually should have a connector from their top left corner to the dotted border coming from their parent comment. That could probably be done with a custom graphic list item.
    
    But you see: your plugin code wasn’t it, it was only minimal layout details :)
    1. etc · 1 November 2012, 22:07 — Reply
      
      Many thanks, Uli, that looks much better indeed! I readily (and regretfully) acknowledge a lack of graphical skills, and the envy to test new features (like multi-column layout) often makes things even worse. But we learn from each other on the Forum, that’s great!
      
      Now going to implement your layout, come back soon!:)
  2. uli · 1 November 2012, 22:08 — Reply
    
    Before I forget it: I had a “Please enter a comment” warning when I submitted. Might be that I exceeded any time limitation and got a standard message, but usually I only need to push Submit again. This time it didn’t work like that, I had to post … two (?) more times. Do I need to reply to someone? Cause initially the Reply-to field was empty when I submitted. Unfortunately I can’t reproduce exactly what I did, sorry.
    1. etc · 1 November 2012, 22:18 — Reply
      
      That’s weird, never met it. Let us put it on the account of the curse of the egyptian urn ash. I’ve made very little modifications, essentially js, and long time ago. Anyway, the code should be optimized, as I see it now, before an eventual release.
Petri · 13 August 2013, 03:48 — Reply

Can’t install on Textpattern 4.5.4. Says:

“Error checking tables.”
1. Oleg · 13 August 2013, 13:41 — Reply
  
  Right, sorry. Please re-download.
  1. candyman · 24 September 2014, 10:57 — Reply
    
    I’ve just tried commenting.
    I’ve noticed that, after you place your comment, this appear without loading the page (nice!) but you can’t place another one without refresh it.
    So, if you have to reply to two (or more) different people you can’t without reloading the page.
    Is this a choose or are there technical problems?
    1. Oleg · 24 September 2014, 13:22 — Reply
      
      It’s the standard behavior of <txp:comments_form /> when you post a comment, I don’t know why.
2. candyman · 24 September 2014, 10:53 — Reply
  
  Just a try.
  1. nemadeka · 1 November 2014, 23:58 — Reply
    
    Testing teh nested comments
Nic · 17 October 2013, 17:16 — Reply

Nice

candyman · 24 September 2014, 22:45 — Reply

I need an help with this plugin: can you post also the CSS styling code you used? I’m trin’ to reply the effect with no result… :(

Thanks in advance.

Oleg · 24 September 2014, 23:16 — Reply

Sure. Here is my comments_display form (simplified):

<h3><txp:comments_invite textonly="1" showalways="1" showcount="0" /></h3>

<txp:if_comments>
	<txp:peg_comments class="comments" form="peg_comments" />
</txp:if_comments>

<txp:if_comments_allowed>
	<txp:comments_form />
<txp:else />
	<p><txp:text item="comments_closed" /></p>
</txp:if_comments_allowed>

then peg_comments comment-type form:

<div id="c<txp:comment_id />">
	<p class="small"><txp:comment_name link="0" /> &#183; <txp:comment_time /> &#8212; <txp:peg_reply_link /></p>
	<txp:comment_message />
</div>

and their css:

.comments .comments {
    border-left: 2px dotted #DDD;
    padding-left: 2em;
    margin-left: 0em;
}
.comments .comments > li {
    list-style: square outside none;
}

You should also append <txp:peg_reply_to /> somewhere inside <txp:comment_form />. Hope that helps.

candyman · 24 September 2014, 23:21 — Reply

Very useful, many thanks! :D
1. Yvonne Lee · 22 April 2022, 05:20 — Reply
  
  COOL COMMENT Plugin
Alessandro · 28 May 2017, 14:13 — Reply

I am trying to uninstall ver 0.2.5 from Textpattern 4.5.7. This is the message I get upon deleting from Plugin tab:

Fatal error: Class ‘Txp’ not found in /home/mhd-01/www.mindfulnessbergamo.net/htdocs/textpattern/lib/txplib_misc.php(615) : eval()’d code on line 1

How can I complete uninstall?

Thanks.

etc_bloatware

Info and download